W.I.P. feat(mobile/navigation): reorganized transitions and added carmode tile view case #15315
+40
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not a fan of showing the same screen in 2 different ways depending on how you ended up on it. There should be a close / back button always, so if someone wants to try it out, from the menu for example, they know how to get back. |
Calinteodor
commented
Nov 18, 2024
| export const carmodeScreenOptionsInTileView = { | ||
| ...carmodeTileViewTransition, | ||
| gestureEnabled: true, | ||
| headerLeft: () => screenHeaderCloseButton(goBack), |
There was a problem hiding this comment.
@saghul As I mentioned in the description, I added a close button after the screen recording was done.
Calinteodor
force-pushed
the
carmode-screen-options
branch
from
1108418
to
54e16d3
Compare
|
From the video it's not clear to me if one can transition into car mode just by swiping, is that in too? |
Calinteodor
force-pushed
the
carmode-screen-options
branch
from
54e16d3
to
0092393
Compare
Calinteodor
changed the title
Calinteodor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trim.5B8B36B5-46E7-40D8-B585-152DF296CCC2.MOV
One detail missing from the screen recording that I added after is the screen header close button.